WIP: Azure Blob Storage Transport (#1)

megahertz / electron-simple-publisher

Simple way to publish releases for electron-simple-updater

MIT License

66 stars 25 forks source link

WIP: Azure Blob Storage Transport (#1) #42

Closed tillbaks closed 4 years ago

tillbaks commented 4 years ago

I like your electron-simple-* stuff but the company I work for uses azure so I made a quick azure transport this morning and thought maybe you would like to include it?

Listing, removing and publishing works. As far as I know. Didn't even know about this "blob storage"-thing yesterday.

Anyway.. you don't seem to use async/await in your transports. Is there a reason for this? Should I change it?

megahertz commented 4 years ago

Thank you for the PR. I'll review it a bit later.

megahertz commented 4 years ago

As for async/await, the only reason transports don't use it - it was developed when it was an experimental node.js feature, so currently it can be used.