search

megahertz / howfat

Shows how fat is a package
MIT License
86 stars 8 forks source link

Do not hardcode default registry.npmjs.org #6

Closed ghost closed 1 year ago

ghost commented 3 years ago

When running this tool against packages hosted on private registries and mirrors, it will not work

https://github.com/megahertz/howfat/blob/00269eac85c184e2e6efffdb45c8370b34332958/src/package/fetchers/NpmFetcher.js#L27

The best way is to inherit the registry from npm configuration or allow to override it through CLI flag. That way, we will gather statistics for private packages as well.

megahertz commented 3 years ago

Thank you, will try to add the feature later

zeroarst commented 2 years ago

Just wondering if this has been updated? Just came across this issue.

megahertz commented 1 year ago

Implemented in v0.3.0