search

megalithic / zk.nvim

Neovim plugin as a lightweight wrapper around https://github.com/mickael-menu/zk
GNU General Public License v3.0
24 stars 11 forks source link

New note links full path on system #25

Open entropitor opened 3 years ago

entropitor commented 3 years ago

When I create a new note with the nice <CR> bindings, it links the full path to the note (including the path to the zk notebook itself) which will break on other systems. How can I avoid that?

Also it seems to put the path in quotes, which the zk LSP then complains about. Is this a bug in the neovim plugin or zk LSP server?

mickael-menu commented 3 years ago

This is a zk.nvim issue, but you can reproduce the same feature with vanilla zk, by triggering the LSP code actions in your editor over the current selection. For example with this mapping with Neovim's built-in LSP client:

buf_set_keymap("v", "<CR>", ":'<,'>lua vim.lsp.buf.range_code_action()<CR>", opts)

See in context

You might need to rebuild your Neovim's nightly, as I recently sent a fix to Neovim to handle range code action properly: https://github.com/neovim/neovim/pull/14555

entropitor commented 3 years ago

The code action is working fine indeed!

So I guess, zk.nvim should use the code that you have on that ticket instead of doing it in the plugin itself? Let the LSP handle it

Thank you so much for the neovim fix! 😍 I noticed it before in with the typescript LSP but I thought it was a bug in the typescript server.