megamanfx / grit-i18n

Automatically exported from code.google.com/p/grit-i18n
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

grit: Can't handle multi-line <link> tags when inlining #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
<link> tags to load .css files aren't inlined when wrapping, i.e.

  <link rel="stylesheet" href="../../blah.css">

works, but

    <link rel="stylesheet"
        href="../../../../../../../../../../../../blah.css">

doesn't.

This is useful because we like to keep HTML files in Chromium to the 80 col 
wrapping rule, so there may be the need to wrap (if possible).

I think the regexp in grit could be updated to handle this case relatively 
easily:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/grit/grit/forma
t/html_inline.py&l=278

Here's a CL to do this:
https://codereview.chromium.org/12289018

Original issue reported on code.google.com by dbeam@chromium.org on 16 Feb 2013 at 2:53

GoogleCodeExporter commented 9 years ago
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176593

Original comment by dbeam@chromium.org on 16 Feb 2013 at 2:56

GoogleCodeExporter commented 9 years ago
My patch was landed by Jói here 
<https://code.google.com/p/grit-i18n/source/detail?r=111>, FYI.

Original comment by dbeam@chromium.org on 27 Feb 2013 at 2:09

GoogleCodeExporter commented 9 years ago
This is fixed now, right? dbeam@, please change status to Verified if that's 
correct.

Original comment by joi@chromium.org on 28 Jun 2013 at 10:32

GoogleCodeExporter commented 9 years ago
don't seem to have edit privileges, but yes, it works now

Original comment by dbeam@chromium.org on 28 Jun 2013 at 6:40