search

meganarlt / MI-449-html-semantic-elements

0 stars 0 forks source link

Project Feedback #1

Open meganarlt opened 4 years ago

meganarlt commented 4 years ago

Create a "Products" page for a fake online store

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

egillespie commented 4 years ago

You've got some solid semantic structure going on here, @meganarlt! I really like the hierarchy of headings across the page. That's great for SEO and for accessibility. Nice work! 👏

I have one recommendation to improve what you've got here. Can you try this out?

Move figures into articles

It looks like your banana and grape figure elements have been placed below the corresponding article elements. Visually, this probably won't be a big deal, but for SEO and people who use screen readers, some of the context is lost when a picture and caption of a fruit is outside of the article meant to tie the rest of that fruit's content together.

Would you mind placing the figure elements inside their corresponding article elements, perhaps between the header and footer?

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 🚀

meganarlt commented 4 years ago

Thanks for the feedback, I think I made the corrections you suggested.

egillespie commented 4 years ago

Nice! I see the figure for the grape is in the article. Would you mind doing the same for the banana figure?

meganarlt commented 4 years ago

Just did the same for the banana figure. Thanks!

egillespie commented 4 years ago

Nailed it. Nice work! 🍌 🍎 🍇 :shipit: