search

meganarlt / MI-449-js-collect-and-display-information

0 stars 0 forks source link

Project Feedback #1

Open meganarlt opened 4 years ago

meganarlt commented 4 years ago

Build a dating profile generator

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

egillespie commented 4 years ago

Hi @meganarlt, the hosted site shows the dating profile generator page, but your code doesn't appear to be running. Would you mind looking into that?

Here's some additional feedback based on my review of the code. Can you touch these up as well?

Generate profile in provided format

It looks like your code is generating a text profile, but the HTML tags and format linked in requirement 1 are missing. Would you mind updating your generated profile string so it resembles the linked format?

Show the profile in Preview and Generated HTML

The code only appears to be putting the generated profile in the Preview section of the page. Would you mind making sure the raw HTML of the profile is also shown in the Generated HTML section?

Describe your changes with commit messages

When you make these changes, can you please describe them in your commit message? Your recent submissions have shown the placeholder "a short message describing your changes".

Using real commit messages is really helpful for seeing how your code has evolved, refreshing your memory of work you've done, and helping others pinpoint changes.

Verify changes before re-submitting

Please make sure to verify your own changes before submitting them. With only a few weeks left in the semester, I understand the desire to move fast. Taking a few minutes to make sure everything works can save you hours of waiting for me to find them and provide feedback, though.

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 🤘