search

meganem / bc-prototype

Repo for developing functional, integrated prototype for Bloomcase
0 stars 0 forks source link

Presentation bug fixing to get it integrated and done #2

Open meganem opened 10 years ago

meganem commented 10 years ago
  1. Review current state of presentation
  2. Send Elijah JS on how slides navigate
  3. Fix styles to work in context of the project template
meganem commented 10 years ago

Line 1746 function viewPresentation() is where this starts in draw_bc.js

It looks like:

  1. There may need to be more slide templates added to the switch statement (slideClass) to accommodate all four, plus the title/end slide template: (1) Full image, (2) Half image, (3) Half map, (4) Full map, (5) Title/end format
  2. We will need an if statement on the image, as slides do not necessarily have images, so if they select Full Image or Half Image templates, then it should not render an tag, instead I will add a background color via CSS.
  3. I'm also wondering why we are rendering the presentation controls in d3/js when we could just drop them in as code in the template? just wondering if there is a reason behind this.

Let me know what you think, and feel free to pass the ticket back to me.

meganem commented 10 years ago

OK, so some more troubleshooting done.

The template you have, case 0 that has "slide-template-project-slide" in it, is what should be used for title and end slides only. That one doesn't have a slide type icon rendering, which a title/end slide would not have.

I've added a gray background (fine for now) to slide-template divs by default, so when there is not image, it shows up gray, BUT we will still need logic to only load a background image when one exists (this is for half and full image templates)

For the half map and full map templates, I will need to remove the gray background (can do in CSS) so that you can show the map underneath. I am not sure you are thinking of this as a new map layer, or of reusing an existing map layer? If the latter, then we also need to hide the zoom controls and make sure the map centers correctly depending on whether it's the full or half map template.

Hopefully this is enough info for now to start tweaking the presentation code?

meganem commented 10 years ago

Action items: