Prevent keyboard/screenreader user from accessing content in sidebar when it's closed

meganesu / generate-gb-opcodes

A helper project to dynamically generate the opcodes for each Game Boy CPU instruction mnemonic

https://meganesu.github.io/generate-gb-opcodes/

42 stars 9 forks source link

Prevent keyboard/screenreader user from accessing content in sidebar when it's closed #17

Open meganesu opened 4 years ago

meganesu commented 4 years ago

Currently, keyboard users can tab to the DetailsSidebar close button even when the sidebar is closed. Instead, the tabbable content inside of DetailsSidebar should be removed from the tab order when the sidebar is not open.

GIVEN the sidebar is closed WHEN I press the tab key repeatedly THEN I should not be able to access the tabbable content inside the sidebar

meganesu commented 4 years ago

See this a11ycast video for more information on this issue: Inert Polyfill -- A11ycasts #02 on YouTube

Use inert polyfill to prevent users from accessing sidebar content when closed: https://github.com/WICG/inert