search

meganesu / generate-gb-opcodes

A helper project to dynamically generate the opcodes for each Game Boy CPU instruction mnemonic
https://meganesu.github.io/generate-gb-opcodes/
42 stars 9 forks source link

Adjustable side window #32

Closed Ech0riginal closed 2 years ago

Ech0riginal commented 3 years ago

Hi! Firstly, I'd like to say this project has been immensely helpful in writing my own gbc emulator, appreciate the work y'all've done. So, it would be amazing if we could get the side window that pops up with an opcode's information to be resizable. I'm able to have the entire table viewable with the sidebar, but it takes up 3/4 of my screen so being able to resize the bar would be really nice. Unfortunately, I'm not a frontend guy otherwise I'd love to just PR this issue, but I don't know jack past basic js.

PS - Apologies if feature requests aren't allowed as issues, it wasn't specified in the contribution guidelines so I thought this the best route to take.

meganesu commented 3 years ago

Hi @Ech0riginal, thanks for opening an issue. I'm glad you've found this site useful! :)

A few questions:

  1. Clarifying the problem: I'd love to get a better understanding of the problem you're encountering. It sounds like you're wanting to be able to see more of the table along with the sidebar content? (Would it be possible for you to add a screenshot of what it looks like on your screen?)
  2. Clarifying the desired behavior: Would you be able to describe more what behavior you'd expect when resizing the sidebar? Is the goal to expose more of the table underneath? Trying to get a better sense of the use case / requirements.

I definitely agree that there are improvements to be made. Thanks for your help, I appreciate it!

vnen commented 3 years ago

I have the same issue. The side window with the description is too wide and cover part of the table, so if I need to select another cell on that area I have to close the sidebar first. And most of the sidebar is blank space, so it doesn't need to that wide. Especially for me, since I use a QHD monitor (2560x1440 resolution). Here's a fullscreen screenshot:

2021-06-06_11-55

You can see that the sidebar is very empty but it gets wide enough to cover that rightmost columns of the table.

nodj commented 3 years ago

Hi! Same as above : the panel is too large by default. I have a great experience with a zoom of 90% and a side panel of 9% of the screen instead of the 40%. It then looks like this: image but I have to edit the properties in chrome's "Inspect" tool.

I don't really know what the best fix for this, as those values are perf for me, but not necessarily for others. Would be awesome if the table content would adapt to the left part, description would adapt to the right part, and user could resize the vertical split. My 2cents.

There is several opcode tables in the wild, but this one is my pref Thank you very much for your work !