meganesu / generate-gb-opcodes

A helper project to dynamically generate the opcodes for each Game Boy CPU instruction mnemonic
https://meganesu.github.io/generate-gb-opcodes/
42 stars 9 forks source link

Incorrect machine cycles for ADC A, r and BIT n, (HL) #34

Closed wsandst closed 3 years ago

wsandst commented 3 years ago

First of all, I want to thank you for making this great opcode table! It was very helpful when I was implementing the CPU for my emulator.

While developing and trying to pass memory timings tests, I noticed that a few of the machine cycle timings were off in the table, compared to the values in the pandocs (https://gbdev.io/pandocs/#instruction-set) and in https://www.pastraiser.com/.

I think it should just be two small changes in ADC_A_r8.js and BIT_b1_memory_at_HL.js. I could do a PR if you're alright with that?

meganesu commented 3 years ago

Hi there, thanks for your patience 😅 Thanks for reaching out to report this error! I think it should be fixed now. Let me know if you see any other problems (or feel free to open a PR).

Thanks again for your help!