search

meganesu / generate-gb-opcodes

A helper project to dynamically generate the opcodes for each Game Boy CPU instruction mnemonic
https://meganesu.github.io/generate-gb-opcodes/
42 stars 9 forks source link

Add information about signed numbers #47

Open raulpy271 opened 2 years ago

raulpy271 commented 2 years ago

I was confused while reading the description of the opcode JR NZ, s8. Which is:

If the Z flag is 0, jump s8 steps from the current address stored in the program counter (PC). If not, the instruction following the current JP instruction is executed (as usual).

The description should say that the s8 argument is a signed number, which are encoded in two's complement. This is a usefull information that is missing in the description.

Do you agree?

Besides, this table in helping me a lot in my journey creating a emulator, thanks.