search

meganesu / generate-gb-opcodes

A helper project to dynamically generate the opcodes for each Game Boy CPU instruction mnemonic
https://meganesu.github.io/generate-gb-opcodes/
42 stars 9 forks source link

Incorrect half-carry and carry flag descriptions on 0xE8 and 0xF8 instructions #51

Open gonzano opened 1 year ago

gonzano commented 1 year ago

Both of these instructions indicate the 16-bit half-carry and carry flags are used, but it should be the 8-bit versions.

I believe the 16-bit half-carry and carry flags are only meant to be used when two 16-bit values are added together and in both of these cases we have a 16-bit value (SP) and an 8-bit value (s8).