Closed xNocken closed 3 years ago
In case this gets merged, then https://github.com/meganrogge/template-string-converter/issues/44 can be reopened too
In reviewing whether this should be merged or not, some things to check are:
Thanks for resolving the issues @xNocken and for the bug reporting @karlhorky.
So this has been released in 0.4.9
right?
Just taking a look at the extension page, it seems like this option is not documented.
@xNocken could you add this to the README.md
, maybe with a gif illustrating the feature?
Done @karlhorky
Thanks!! I'll have to re-enable this and give it a try extensively.
Ok, so it seems this feature is still somewhat buggy:
It erroneously makes the following tagged template string into a double-quoted string, when hitting backspace anywhere inside the template string.
Notice there are no interpolations. It's important that it stay as a tagged template string.
export async function down(sql: Sql<{}>) {
await sql`DROP TABLE reset_password_requests`;
}
I'm guessing the logic for this code for this feature is:
This is maybe almost ok, but should probably do some better checks:
${
and }
present in the string) AND there is NO interpolation AFTER hitting backspace:
That seems like it would be a much more robust start of an implementation (probably also has weird edge cases, but at least it's much better than what's there now).
related issues: #47 #43