search

meganrogge / template-string-converter

Autocorrect from quotes to backticks
MIT License
194 stars 24 forks source link

Simplify the setting template-string-converter.filesExcluded #79

Closed a-stewart closed 2 years ago

a-stewart commented 2 years ago

This setting works currently be looping over all keys in the provided object and if the value is truthy, it will compare the filepath against the object key, and if that matches it will exclude the file.

In practice, the setting is just a list of patterns which are checked, and that can be implemented in a much simpler way, which will also allow for the settings to be configured in the settings editor, rather than requiring settings.json to be manually edited.

I have done a quick google, and there is nothing referencing this setting other than the issue #58 that requested it. I think it should be safe to make changes to that setting.

meganrogge commented 2 years ago

just conflicts to resolve, ow LGTM thanks

a-stewart commented 2 years ago

I've merged in latest master. Thanks for the review :)