False-positive if name resolving isn't working

meganukebmp / Switch_90DNS_tester

A simple homebrew application to test 90DNS or Atmosphere DNS MITM on the switch (https://gitlab.com/a/90dns)

GNU Lesser General Public License v3.0

244 stars 21 forks source link

False-positive if name resolving isn't working #3

Closed hrvylein closed 3 years ago

hrvylein commented 3 years ago

Hey,

while using switch-lan-play i stumbled upon the issue i described here: https://github.com/spacemeowx2/switch-lan-play/issues/114

spacemeowx2 found the corresponding place in your code. Your code is working correctyl as dns resolving isn't returning 127.0.0.1 as the ip, but as the gateway is not working, internet access is blocked at all.

Maybe change the message to a yellowish color with message "unblocked (not resolved)" or sth similiar?

meganukebmp commented 3 years ago

Sorry for late reply. Confirmed. It also returns unblocked when the connection is off completely (wifi off). I'll add the corresponding checks asap. Thanks!

meganukebmp commented 3 years ago

Thanks for reporting. This issue has been resolved!