search

meganukebmp / Switch_90DNS_tester

A simple homebrew application to test 90DNS or Atmosphere DNS MITM on the switch (https://gitlab.com/a/90dns)
GNU Lesser General Public License v3.0
244 stars 21 forks source link

[Suggestion] Add a domain that shouldn't be blocked to the test #6

Closed ghost closed 1 year ago

ghost commented 2 years ago

Hello.

Small suggestion : what about adding, for example, Google, to the test? This way you could be more certain your network is working properly, running the test when offline gives the same result as successfully blocking the correct domains.

DraconicNEO commented 1 year ago

Addressed in pull request #8

meganukebmp commented 1 year ago

running the test when offline gives the same result as successfully blocking the correct domains.

Is this not ultimately true? Offline means no connection. I've added a warning that there is no network with 23d2cf64908fa1728130c242444b0c2daf3b8908. I believe this should be sufficient. Adding unrelated to nintendo domains also means that logic should be updated to show such entries as green, since having them unlocked is not a negative. As a simple testing program I want it to be clear when a block is a full block and when it is not. All greens = OK. Red and yellow = Caution.

I'll close this as resolved with 23d2cf64908fa1728130c242444b0c2daf3b8908. Feel free to reopen if you'd propose something else.

DraconicNEO commented 1 year ago

running the test when offline gives the same result as successfully blocking the correct domains.

Is this not ultimately true? Offline means no connection. I've added a warning that there is no network with 23d2cf6. I believe this should be sufficient. Adding unrelated to nintendo domains also means that logic should be updated to show such entries as green, since having them unlocked is not a negative. As a simple testing program I want it to be clear when a block is a full block and when it is not. All greens = OK. Red and yellow = Caution.

I'll close this as resolved with 23d2cf6. Feel free to reopen if you'd propose something else.

I was thinking that including some domains that shouldn't be blocked that are used by Homebrew would be a good idea since it could show network problems that aren't necessarily related to just not having Wi-Fi or Flight Mode turned on.

meganukebmp commented 1 year ago

I was thinking that including some domains that shouldn't be blocked that are used by Homebrew would be a good idea since it could show network problems that aren't necessarily related to just not having Wi-Fi or Flight Mode turned on.

This tool only does DNS resolution checks. It doesn't check if a host is reachable or even if it exists. All it does is ask the DNS server what a domain maps to. It cannot show further network issues other than DNS misconfiguration. In the context of of blocking Nintendo domains this means whether or not they are redirected to localhost. Localhost = green, everything else = not green. I think it's sufficient and compact enough for what it does.