SDK-1397. Introduce NodeHandle helper class, fix some tests

mattw-mega commented 3 years ago

This PR is starting to merge some improvements back from the sync rework branch

adding NodeHandle class. It wraps up 6 byte node handles, to avoid accidental 8 byte usages, and avoid common mistakes with compiler errors/warnings, and asserts.
Fix some test cases where the listeners were not being used, and race conditions caused the tests to get confused.
The File class is updated to use NodeHandle - it's a good place to start as the handle contained there is not referenced by too many lines.
Over time other usages should migrate to NodeHandle also, and eventually we should be able to do away with the (deliberately awkward) set6byte() and as8byte() members.

JenkinsMega commented 3 years ago

megasdk_PR FAILED (3906) :-1:

JenkinsMega commented 3 years ago

megasdk-crossAndroid-PRs SUCCEDED (1563) :+1:

JenkinsMega commented 3 years ago

megasdk-winx64-PRs FAILED (1388) :-1:

JenkinsMega commented 3 years ago

megasdk-crossAndroid-PRs SUCCEDED (1579) :+1:

JenkinsMega commented 3 years ago

megasdk_PR FAILED (3922) :-1:

JenkinsMega commented 3 years ago

megasdk-winx64-PRs FAILED (1405) :-1:

JenkinsMega commented 3 years ago

megasdk_PR FAILED (3923) :-1:

JenkinsMega commented 3 years ago

megasdk-crossAndroid-PRs SUCCEDED (1580) :+1:

mattw-mega commented 3 years ago

trigger compilation

JenkinsMega commented 3 years ago

megasdk-winx64-PRs SUCCEDED (1406) :+1:

JenkinsMega commented 3 years ago

megasdk-crossAndroid-PRs SUCCEDED (1581) :+1:

JenkinsMega commented 3 years ago

megasdk_PR SUCCEDED (3924) :+1:

JenkinsMega commented 3 years ago

megasdk-winx64-PRs FAILED (1407) :-1:

meganz / sdk