search

meganz / sdk

MEGA C++ SDK
BSD 2-Clause "Simplified" License
1.33k stars 509 forks source link

SDK-1403 - Correctly check whether a local path is syncable. #2560

Closed dwmega closed 3 years ago

dwmega commented 3 years ago

The SDK calls isLocalPathSyncable(...) to determine whether a given local path is acceptable.

One of the checks it performs is to verify that there is only a single active sync for a given local path.

There are times where isLocalPathSyncable(...) is called after the sync for a given path has already been committed to memory. Say, when enabling a sync. For this reason, isLocalPathSyncable(...) allows the caller to skip checking against a specified Backup ID. This prevents the function from comparing a given sync against itself.

The purpose of this change-set is to correct the logic that performs that skipping.

JenkinsMega commented 3 years ago

megasdk-crossAndroid-PRs SUCCEDED (1601) :+1:

JenkinsMega commented 3 years ago

megasdk_PR SUCCEDED (3944) :+1:

JenkinsMega commented 3 years ago

megasdk-winx64-PRs FAILED (1427) :-1:

JenkinsMega commented 3 years ago

megasdk-crossAndroid-PRs SUCCEDED (1603) :+1:

sergiohs84 commented 3 years ago

This branch needs to be a hotfix for v3.8.2, and it was forked from develop. Closing in pro of https://github.com/meganz/sdk/pull/2561 and https://github.com/meganz/sdk/pull/2562

JenkinsMega commented 3 years ago

megasdk_PR SUCCEDED (3946) :+1:

JenkinsMega commented 3 years ago

megasdk-winx64-PRs SUCCEDED (1429) :+1: