search

meganz / sdk

MEGA C++ SDK
BSD 2-Clause "Simplified" License
1.34k stars 508 forks source link

Compilation support on various BSDs #2661

Closed kikadf closed 2 weeks ago

kikadf commented 8 months ago

I am a satisfied user of the MEGA service, thank you for your work. I use the mega-sdk (megacmd) on Linux, on FreeBSD, as well as with minor modifications DragonFly BSD, NetBSD, and OpenBSD. In the case of FreeBSD and NetBSD, I maintain the megacmd package that is available in their package repositories, but I use it with full functionality and without issues on all BSD systems.

I am sending some pull requests that make successful compilation on the various BSDs.

I understand that DragonFly, NetBSD, and OpenBSD are not officially supported platforms and there are no plans for that, however, only simple changes (that do not affect other platforms) are needed to make the mega-sdk compile on these systems as well.

I hope you find these acceptable and worth to merging.

sergiohs84 commented 2 weeks ago

Hi @kikadf . Thanks a lot for your contribution. I've closed 2 out of 4 PRs you created, since they are obsolete. However, for the other two, we will add them to our internal repository first. We will notify you when they are merged and published in GitHub. Once again, thank you.

sergiohs84 commented 2 weeks ago

Your changes will be included in the next release ;)

image

Thanks for your contribution.

kikadf commented 2 weeks ago

Your changes will be included in the next release ;)

Thank you!

sergiohs84 commented 1 week ago

Well, the MR missed the next release (8.0.0, not live yet), but it's already merged in our develop branch, so it will definitely added to the next release after 8.0.0. Thanks