search

meganz / webclient

The mega.nz web client
Other
1.06k stars 310 forks source link

Advertisements with Extension #88

Closed Merith-TK closed 3 years ago

Merith-TK commented 3 years ago

Resolved, see first comment

I am viewing a download for a game I play, and I notice it has advertisements, Problem, I have an adblocker built into my browser AND a (DNS Level Adblocker)[https://pi-hole.net] So theoretically, I should not see any ads at all, however I am seeing ads from na.megaad.nz, 

<div class="bottom-page table-row dl-ads dl-top-ads ads-active"><iframe type="content" class="gadvs-frame wpht" width="728" height="90" sandbox="allow-scripts allow-popups allow-same-origin" frameborder="0" src="https://na.megaad.nz/?iu=%2F22060108601%2Fwph%2Fwph_t&amp;tile=3&amp;c=16285234071035627&amp;w=728&amp;h=90"></iframe></div>

[[ Removed Google Ad Content ]]

(file content censored as it is NSFW) https://user-images.githubusercontent.com/10422110/128733924-b0cc4191-6b94-4bcd-8bbd-0cc9cd28230c.png

I use mega specifically because of the privacy that was promised at the time, and still is promised on the website. Google Ads contain trackers, allowing google to know what links you visit, and what resources you accessed in your browser. I have multiple layers of adblocking specifically to prevent this unless I am accessing an official google site like youtube or gmail,

Along with the detail that no where in the source code for the extension, do I see any form of reference to megaad or google ads, or g.co, meaning there is shenanigans being pulled between the source code and the release outside of the usual tweaks for security and branding that I am sure occurs behind the scenes,

I have had an account with mega since atleast 2017, maybe late 2016, and this has been the only complaint I am have had with Mega, ever,

Browser information

Microsoft Edge:    92.0.902.67 (Official build) (64-bit)
Revision:          eda2f229828b8182304335674621190ceba97ecd
Operating system:  Windows 10 OS Version 2004 (Build 19041.1110)
JavaScript:        V8 9.2.230.22
User agent:        Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.131 Safari/537.36 Edg/92.0.902.67

Extension was installed through Edge's Store rather that Googles

diegocr commented 3 years ago

Hello, those advertisements are provided on an iframe with "sandbox" attributes, this should guarantee the MEGA link you're into and/or any information tied to you or your account is not leaked and therefore your privacy is preserved.

If anyway the adverts does annoy you, you can disable them by opening the hamburger menu, and under "Legal and Policies" -> "Cookie settings" disable "Third Party Cookies" and you shouldn't see them any longer.

Hope this helps, regards.

Merith-TK commented 3 years ago

Oh that worked! thank you, I will rename the issue so people who come looking can see it

diegocr commented 3 years ago

Your welcome, note however this is unrelated to the extension being used.

Merith-TK commented 3 years ago

The detail that conventional adblockers, and even "unconventional" such as PiHole, which works at the DNS level, and should block access to these domains by default, is related to the extension

—Merith

On Mon, Aug 9, 2021 at 9:58 AM Diego Casorran @.***> wrote:

Your welcome, note however this is unrelated to the extension being used.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/meganz/webclient/issues/88#issuecomment-895384100, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPQOXURZVI7SA7B5MTRSXTT4ACMRANCNFSM5B2MEFBA .