search

megastef / node-crate

Node.js base DB-Driver for CRATE (www.crate.io)
52 stars 18 forks source link

Master #12

Closed waysay closed 7 years ago

waysay commented 8 years ago

Updated the .update() call to accept a full object like the .insert() function does. Ran into a lot of trouble with nested objects using the old .update().

megastef commented 7 years ago

Thx. I will check the PR tomorrow, sorry i completly missed the email notifications in the past.

megastef commented 7 years ago

Output of "npm test": 


standard: Run `standard --fix` to automatically fix some problems.
  /Users/stefan/sematext/node-crate/lib/index.js:69:10: 'prepareOptionsInsert' is defined but never used.
  /Users/stefan/sematext/node-crate/lib/index.js:74:14: Strings must use singlequote.
  /Users/stefan/sematext/node-crate/lib/index.js:76:12: Strings must use singlequote.
  /Users/stefan/sematext/node-crate/lib/index.js:76:23: Strings must use singlequote.
  /Users/stefan/sematext/node-crate/lib/index.js:278:26: Extra semicolon.
  /Users/stefan/sematext/node-crate/lib/index.js:279:5: Expected space(s) after "for".
  /Users/stefan/sematext/node-crate/lib/index.js:279:57: Missing space before opening brace.
  /Users/stefan/sematext/node-crate/lib/index.js:280:51: Strings must use singlequote.
  /Users/stefan/sematext/node-crate/lib/index.js:280:85: Extra semicolon.```
vincic commented 7 years ago

does this pull request solve nested objects and array of objects when updating/inserting? I have a commit here https://github.com/vincic/node-crate/commit/77e98cf248b7bd0f83c40c66933a712afda9817f which I forgot to do PR on that does that?