search

megastruktur / foundryvtt-blades-in-the-dark

Blades In The Dark game system for FoundryVTT
Other
37 stars 103 forks source link

Faction sheet: clicking on second clock doesn't work properly #186

Open ben opened 2 years ago

ben commented 2 years ago

The first clock seems to have its wedges associated properly, but the second one is really broken:

https://user-images.githubusercontent.com/39902/198161724-583f1049-2529-4d42-af4e-47db198964ee.mp4

justinross commented 2 years ago

I’ve squashed a few of these bugs. They’re usually caused by using a template-generated id (html element attribute, that is) that isn’t unique. I’ll take a look if nobody else gets to it. It’s usually as easy as adding the actor ID to the generated element ID (and making sure you do the same for any associated input elements).

Justin On Oct 26, 2022 at 5:13 PM -0700, Ben Straub @.***>, wrote:

The first clock seems to have its wedges associated properly, but the second one is really broken: https://user-images.githubusercontent.com/39902/198161724-583f1049-2529-4d42-af4e-47db198964ee.mp4 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

drewg13 commented 1 year ago

The ids were wonky, but there was also a 1 where there should have been a 2 for the second clock. I pushed a PR.