megawac / qwebirc-enhancements

Rich and intuitive browser IRC client.
http://justplay.tf/irc
Other
22 stars 10 forks source link

Installation (post-install/config) #17

Closed krittick closed 10 years ago

krittick commented 10 years ago

Not sure if I'm missing a step that's not mentioned in the readme, but using the latest master code results in the below error when navigating to the instance:

Uncaught TypeError: Cannot read property 'speech' of undefined qwebirc-0.97.0.js:877

(using non-minified, non-cdn for debugging)

Hardcoding the value to what it's set to in the constants variable in the code just leads to other similar errors for other variables. Upon checking the console, "constants" does not exist as a variable at all in the compiled js.

The steps in the readme don't appear to actually start a node or twisted instance, if that could be the cause, but that's not mentioned anywhere if so.

megawac commented 10 years ago

Think I fixed this in https://github.com/megawac/qwebirc-enhancements/commit/a488f83ec2a45a2c4eb274807211788f7018ad97

It was an issue with requiring dependencies in the wrong order

Thanks

megawac commented 10 years ago

As far as building running the code the work flow is something like this:

krittick commented 10 years ago

Thanks, I kinda figured it was related to needing an instance running and I hadn't considered that it'd be in a different project. Was used to the original qwebirc including it all.

I'll give that build order a shot this evening and see how it goes.

megawac commented 10 years ago

I need to figure out a way to streamline that process... I'll look into it this weekend

megawac commented 10 years ago

@krittick I couldnt get this out of my head and I've add a quick prototype way to do it similar to the old qwebirc compile process to my iris fork

Problem its not finished... Still got to pass items from the config file to the static process or its not going to be customizable -- going to have to make a map. I'm heading out I'll think about this another night

krittick commented 10 years ago

Couldn't you make compile.py interactive and request the config values from the user then? I'm sure you have a final method planned for doing this so it might not be ideal. I use this approach in another app I develop so I figured I'd mention it before I was able to try the steps tonight.

megawac commented 10 years ago

I was thinking about doing that when I started the project, however I'm pretty sure the user would be half ready to jump on a plane to gut me by the time they finished entering all the config inputs.

I started adding them to this file in the Python-compile branch