search

megawac / qwebirc-enhancements

Rich and intuitive browser IRC client.
http://justplay.tf/irc
Other
22 stars 10 forks source link

auth stall on connect / during hostname lookup #2

Closed n0risc closed 11 years ago

n0risc commented 11 years ago

[22:06] qwebirc v0.93-dev [22:06] Copyright (C) 2008-2011 Chris Porter and the qwebirc project. [22:06] http://www.qwebirc.org [22:06] Licensed under the GNU General Public License, Version 2. [22:06] == * (qwebirc) Looking up your hostname... [22:06] == * (qwebirc) Found your hostname. [22:06] == Connected to server. [22:06] -AUTH> :#brouhaha- * Looking up your hostname... [22:06] - :AUTH- * Looking up your hostname...

Dead.

Debug:

using localStorage qwebirc-0.93dev.js:10983 using sessionStorage qwebirc-0.93dev.js:10983 todo qwebirc-0.93dev.js:21016 Uncaught TypeError: Cannot call method 'getScroll' of null qwebirc-0.93dev.js:8647 ["qwebirc v0.93-dev", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["qwebirc v0.93-dev", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["qwebirc v0.93-dev", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["qwebirc v0.93-dev", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 qwebirc v0.93-dev qwebirc-0.93dev.js:21564 ["Copyright (C) 2008-2011 Chris Porter and the qwebirc project.", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["Copyright (C) 2008-2011 Chris Porter and the qwebirc project.", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["Copyright (C) 2008-2011 Chris Porter and the qwebirc project.", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["Copyright (C) 2008-2011 Chris Porter and the qwebirc project.", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 Copyright (C) 2008-2011 Chris Porter and the qwebirc project. qwebirc-0.93dev.js:21564 ["http://www.qwebirc.org", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["http://www.qwebirc.org", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["http://www.qwebirc.org", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["http://www.qwebirc.org", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 http://www.qwebirc.org qwebirc-0.93dev.js:21564 ["Licensed under the GNU General Public License, Version 2.", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["Licensed under the GNU General Public License, Version 2.", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["Licensed under the GNU General Public License, Version 2.", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["Licensed under the GNU General Public License, Version 2.", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 Licensed under the GNU General Public License, Version 2. qwebirc-0.93dev.js:21564 ["== * (qwebirc) Looking up your hostname...↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["== * (qwebirc) Looking up your hostname...↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["== * (qwebirc) Looking up your hostname...↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["== * (qwebirc) Looking up your hostname...↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 == * (qwebirc) Looking up your hostname... qwebirc-0.93dev.js:21564 ["== * (qwebirc) Found your hostname.↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["== * (qwebirc) Found your hostname.↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["== * (qwebirc) Found your hostname.↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["== * (qwebirc) Found your hostname.↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 == * (qwebirc) Found your hostname. qwebirc-0.93dev.js:21564 ["== Connected to server.↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["== Connected to server.↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["== Connected to server.↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["== Connected to server.↵", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 == Connected to server. qwebirc-0.93dev.js:21564 ["-", "<irc.onsitepool.net>AUTH>↵", ":#brouhaha- * Looking up your hostname...", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["-<span class='hyperlink-whois' data-user='irc.ons…pan>↵:#brouhaha- * Looking up your hostname...", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["-<span class='hyperlink-whois' data-user='irc.ons…pan>↵:#brouhaha- * Looking up your hostname...", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["-<span class='hyperlink-whois' data-user='irc.ons…pan>↵:#brouhaha- * Looking up your hostname...", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 -<irc.onsitepool.net>AUTH> :#brouhaha- * Looking up your hostname... qwebirc-0.93dev.js:21564 ["-", "<irc.onsitepool.net>↵", ":AUTH- * Looking up your hostname...", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["-<span class='hyperlink-whois' data-user='irc.ons…t;↵:AUTH- * Looking up your hostname...", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["-<span class='hyperlink-whois' data-user='irc.ons…t;↵:AUTH- * Looking up your hostname...", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 ["-<span class='hyperlink-whois' data-user='irc.ons…t;↵:AUTH- * Looking up your hostname...", $family: function, $constructor: function, each: function, clone: function, clean: function…] qwebirc-0.93dev.js:21551 -<irc.onsitepool.net> :AUTH- * Looking up your hostname... qwebirc-0.93dev.js:21564 Uncaught ReferenceError: type is not defined qwebirc-0.93dev.js:18821

n0risc commented 11 years ago

Keep in mind I'm using my config.py.. But the supplied atf2config.py.back is almost identical except for web CGI:IRG is set as webirc to auth to the ircd.

megawac commented 11 years ago

Going to have to look into that but can you confirm the referenceerror is on this function:

IRCClient -> nickChanged:

function(user, newnick, wasus) { var self = this, oldnick = util.hostToNick(user);

    if (wasus) {
        self.nickname = newnick;
        storage.set('nickname', newnick);
    }

    self.tracker.renameNick(oldnick, newnick);

    var channels = self.tracker.getNick(newnick);
    var found = Object.getLength(channels) > 0;

    Object.each(channels, function(obj, chan) {
        self.newChanLine(chan, "NICK", user, {
            "w": newnick
        });
        // TODO: rename queries
        self.updateNickList(chan);
    });

    if (!found) {
        self.newServerLine("NICK", {
            "w": newnick,
            n: util.hostToNick(user),
            h: util.hostToHost(user),
            "-": self.nickname
        });
    }

    self.fireEvent("nickChange", {
        'user': user,
        'newnick': newnick,
        'channels': channels,
        'thisclient': wasus,
        'client': self
    });
}
n0risc commented 11 years ago

chat error1 chat error2

megawac commented 11 years ago

The getScroll of null is a mootools bug calculating offset parent, dont worry about that

The type of undefined is bugging me as I haven't seen it before. Can you go in your source file and make sure thats pointing to nickChange function

n0risc commented 11 years ago

nickChanged: function(user, newnick, wasus) { var self = this, oldnick = util.hostToNick(user);

    if (wasus) {
        self.nickname = newnick;
        storage.set('nickname', newnick);
    }

    self.tracker.renameNick(oldnick, newnick);

    var channels = self.tracker.getNick(newnick);
    var found = Object.getLength(channels) > 0;

    // for (var chan in channels) {
    //     found = true;

    //     self.newChanLine(chan, "NICK", user, {
    //         "w": newnick
    //     });
    //     // TODO: rename queries
    //     self.updateNickList(chan);
    // }
    Object.each(channels, function(obj, chan) {
        self.newChanLine(chan, "NICK", user, {
            "w": newnick
        });
        // TODO: rename queries
        self.updateNickList(chan);
    });

    if (!found) {
        self.newServerLine("NICK", {
            "w": newnick,
            n: util.hostToNick(user),
            h: util.hostToHost(user),
            "-": self.nickname
        });
    }

    self.fireEvent("nickChange", {
        'user': user,
        'newnick': newnick,
        'channels': channels,
        'thisclient': wasus,
        'client': self
    });
},

initialTopic: function(channel, topic) {
    this.getWindow(channel).updateTopic(topic);

    this.fireEvent("channelTopic", {
        'channel': channel,
        'topic': topic
    });
},

channelTopic: function(user, channel, topic) {
    this.newChanLine(channel, "TOPIC", user, {
        "m": topic
    });
    this.getWindow(channel).updateTopic(topic);

    this.fireEvent("channelTopic", {
        'user': user,
        'channel': channel,
        'topic': topic
    });
},

channelPrivmsg: function(user, channel, message) {
    var self = this,
        nick = util.hostToNick(user);

    self.tracker.updateLastSpoke(nick, channel, Date.now());
    self.newChanLine(channel, "CHANMSG", user, {
        "m": message,
        "@": self.getNickStatus(channel, nick)
    });

    self.fireEvent("channelMessage", {
        'user': user,
        'channel': channel,
        'message': message
    });
},

channelNotice: function(user, channel, message) {
    this.newChanLine(channel, "CHANNOTICE", user, {
        "m": message,
        "@": this.getNickStatus(channel, util.hostToNick(user))
    });

    this.fireEvent("channelNotice", {
        'user': user,
        'channel': channel,
        'type': type
    });
},
n0risc commented 11 years ago

Fixed...

Changed:

this.fireEvent("channelNotice", { 'user': user, 'channel': channel, 'type': type });

To:

this.fireEvent("channelNotice", { 'user': user, 'channel': channel });

Client is connecting, and Auto Joining Channels.

megawac commented 11 years ago

rofl im dumb sorry