search

megbedell / wobble

precise data-driven RV fitting, now with tellurics!
https://wobble.readthedocs.io
MIT License
39 stars 16 forks source link

there are two likelihood functions with repeated code #3

Closed davidwhogg closed 6 years ago

davidwhogg commented 6 years ago

hogg say: make a self.lnlike_parts() that contains all the repeated code

megbedell commented 6 years ago

fixed some of this, but there's still edits to be made in the "improve model" and d(lnlike)/dw functions to eliminate duplicate code

megbedell commented 6 years ago

Fixed the model and d(lnlike)/dw functions to have less duplication. There's still a bit more duplication that could be eliminated by getting clever with the state function, but I'm calling this done for now at least!