Adding unit test and fixing gradients for new interp op

megbedell / wobble

precise data-driven RV fitting, now with tellurics!

https://wobble.readthedocs.io

MIT License

39 stars 16 forks source link

Adding unit test and fixing gradients for new interp op #69

Closed dfm closed 5 years ago

dfm commented 5 years ago

Here's an update to the new interp op where the gradients are now correct. It doesn't want to merge since you reverted the previous change, but you should try it out and see if it works for you. The test you sent me in #68 seems to be fine now.

dfm commented 5 years ago

Ok - I think I fixed the merge conflicts. Give it a shot and let me know!

megbedell commented 5 years ago

Thanks, this is working now - although I'm not sure that it speeds up performance noticeably vs. the old version of interp. Do you see improvement on your machine?

megbedell commented 5 years ago

nvm actually it is faster! thanks @dfm!!! you da 💣

dfm commented 5 years ago

Awesome!!

davidwhogg commented 5 years ago

Sick!!