search

meggart / DiskArrays.jl

Other
73 stars 13 forks source link

fix CartesianIndices in batchgetindex #108

Closed rafaqz closed 6 months ago

rafaqz commented 1 year ago

This PR uses the strategy previously on Vector{Int} for all indexing to avoid bugs like #84. It uses view instead of getindex to avoid large allocations.

Fixes #84

rafaqz commented 1 year ago

Any comments on this one @meggart

meggart commented 6 months ago

Superseded by #146