meggart / DiskArrays.jl

Other
72 stars 13 forks source link

`cat` should work for iterators of Ints #133

Closed felixcremer closed 7 months ago

felixcremer commented 7 months ago

According to the documentation of cat it should be possible to call it with an iterable of dimensions so that the "the positions along these dimensions are increased simultaneously for each input array, filling with zero elsewhere. This allows one to construct block-diagonal matrices as cat(matrices...; dims=(1,2)), and their higher-dimensional analogues."

We should try to adhere to this interface and I am wondering whether we would need to have a new type ConcatBlockDiskArray to overload the writeblock and readblock functions.

This part of the cat interface is used for example in DimensionalData. Therefore we can't currently use cat of a DiskArray backed AbstractDimArray.