search

meggart / DiskArrays.jl

Other
72 stars 13 forks source link

Remove length from Stateful Iterators #142

Closed wkearn closed 6 months ago

wkearn commented 7 months ago

CI is failing on nightly because of this change: https://github.com/JuliaLang/julia/pull/51747

DiskArrays calls length on a Stateful iterator here:

https://github.com/meggart/DiskArrays.jl/blob/3689544f68f2ac10db8b6f127384df892a1a913f/src/iterator.jl#L40-L60

rafaqz commented 7 months ago

Surely this is a breaking change to julia Base?

rafaqz commented 7 months ago

@meggart we may need to define our own DiskStateful iterator and define length on it as in this case we know it is correct.

felixcremer commented 6 months ago

This is closed by #145 .