meggart / DiskArrays.jl

Other
72 stars 13 forks source link

Add test for Bool indexing with an indexing vector that batches #157

Closed felixcremer closed 5 months ago

felixcremer commented 6 months ago

The test failed for me before you committed the dispatch changes for Bool in 387d910501cf5f6c37ea154e5543fca74aaa5a1c The boolean vector is set so that the needs_batch function returns true.

meggart commented 6 months ago

Thanks for adding this. In order to not clutter the tests too much, could you maybe add this to the testset "Getindex/Setindex with vectors" instead of making a new one?