search

meggart / DiskArrays.jl

Other
72 stars 13 forks source link

Avoid allocation of temp array for dense data reads and writes #161

Closed meggart closed 5 months ago

meggart commented 5 months ago

This is a mere optimization and tries to avoid allocating a temporary array wherever possible during getindex/setindex calls.

meggart commented 5 months ago

@rafaqz I don't know if you would like to have a look. This PR also includes the DiskIndex struct you were suggesting instead of returning the long tuple from process_index. In addition I extended the getindex and setindex tests so we test combinations of all types of different indexing, which revealed a few additional hidden bugs. I also completely removed the assume_effects macro for now, since the function infers also without this. So this passes tests on 1.9 now.