search

meggart / DiskArrays.jl

Other
72 stars 13 forks source link

Fix undef writes in setindex take 2 #173

Closed meggart closed 3 months ago

meggart commented 3 months ago

Supersedes #172 .

Actually there were multiple thing going on in this

  1. Broken dispatch that led to setindex not using passing a steprange to writeblock although NCDatasets indicates its capacity to process these by setting CanStepRange
  2. Sending undefined data to getindex. It was very lucky that you included a test with Strings, for other data types the error was there as well but did not surface because these undef arrays are filled with garbage data then. This is fixed now.