meggart / DiskArrays.jl

Other
72 stars 13 forks source link

Fix CachedDiskArrays #177

Closed meggart closed 1 month ago

meggart commented 1 month ago

The original implementation assumed that readblock! of the parent array would return, which is not generally true. In this modified version I fixed this and by the made gave the cache a concrete type. Also I avoided the construction of a ConcatDiskArray which is generally quite slow.

I was working on this for a use case where we needed random access to single elements of a cached DiskArray so the the overhead of redablock! itself was apparent.

@felixcremer and maybe @SimonDanisch in case you rely on this could you maybe test if this still works for your use cases before I merge?