search

meggart / SentinelMissings.jl

Other
8 stars 0 forks source link

remove type piracy of `convert(Any, x)` #4

Open simeonschaub opened 2 years ago

simeonschaub commented 2 years ago

convert(Any, x) should always be a noop, but it seems like this package intentionally overloads it with a different meaning:

https://github.com/meggart/SentinelMissings.jl/blob/b69ab6cd9ea4ac44ab2920ca411ffe92a69df30b/src/SentinelMissings.jl#L11

This will likely cause issues once https://github.com/JuliaLang/julia/pull/43671 is merged, so this should be removed or a different function should be used for this instead.

simeonschaub commented 2 years ago

It also seems like https://github.com/meggart/YAXArrays.jl ships a copy of this, so that probably needs to change accordingly as well.

meggart commented 2 years ago

Thanks a lot for the hint. I will remove this.