meghapsimatrix / simhelpers

Helper package to assist in running simulation studies
10 stars 3 forks source link

CRAN release for furrr #14

Closed DavisVaughan closed 2 years ago

DavisVaughan commented 2 years ago

Hi there,

I have run revdeps for furrr and your package appeared in the checks.

It seems the CRAN version of your package still uses future_options(). This is now defunct in furrr.

I can see that you have removed it in favor of furrr_options() here, which is great! https://github.com/meghapsimatrix/simhelpers/commit/dae31e311ae13a2d4581a89edc49eb7b1b827d00

You should also remove this @importFrom line here: https://github.com/meghapsimatrix/simhelpers/blob/dae31e311ae13a2d4581a89edc49eb7b1b827d00/R/evaluate_by_row.R#L32

After you do that, is there any way you can submit simhelpers to CRAN very soon? The furrr release is otherwise ready to go.

Thanks!

DavisVaughan commented 2 years ago

If you don't feel like you can get simhelpers out in 2 days or so, that's fine too! Just let me know and I will submit to CRAN anyways, and CRAN will give you a 2 week warning to submit a fix

jepusto commented 2 years ago

I'll take a look at this today. We may be able to get a CRAN submission turned around. Will let you know by tomorrow morning if it's not in the cards.

On Tue, May 3, 2022 at 8:55 AM Davis Vaughan @.***> wrote:

If you don't feel like you can get simhelpers out in 2 days or so, that's fine too! Just let me know and I will submit to CRAN anyways, and CRAN will give you a 2 week warning to submit a fix

— Reply to this email directly, view it on GitHub https://github.com/meghapsimatrix/simhelpers/issues/14#issuecomment-1116128950, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCVGIR624M5ZGZZUYYQN6DVIEV3JANCNFSM5U66T6CQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

DavisVaughan commented 2 years ago

Thank you!

jepusto commented 2 years ago

Version 0.1.2 is on its way to CRAN.

DavisVaughan commented 2 years ago

Great, thank you!