meghapsimatrix / simhelpers

Helper package to assist in running simulation studies
10 stars 3 forks source link

James check Jacknife stuff #3

Closed meghapsimatrix closed 4 years ago

meghapsimatrix commented 4 years ago

Please 😸

jepusto commented 4 years ago

Looking this over. For the Welch simulations, I think it would be better to use unequal sample sizes so that the variance estimates for the regular t-test are different than for the Welch t-test. With equal sample sizes, they're identical, which makes the example of relative bias calculations less interesting.

meghapsimatrix commented 4 years ago

Thanks for the comment. I was thinking of doing that but been distracted. I just changed it so that there is equal size (50, 50) and unequal (50, 70) and it definitely shows in relative var and in type 1 error and conf intervals. I need to double check all the vignettes to make sure they are consistent with this change. Thanks a lot again! Good night!

meghapsimatrix commented 4 years ago

One comment. On the relative RMSE MCSE formula you wrote 1/ K times theta squared image

But that doesn't show up in the relative variance table image

I think if you think that squared theta should be added to relative rmse it should be added to all the relative variance estimates, right?

If I need to add it, I need to change all the formulas in the functions.

jepusto commented 4 years ago

This depends on how you're doing the jackknife. In the first case (where the true parameter value is known), are you jackknifing the raw RMSE or the relative RMSE? If raw, then you'll need to divide by the parameter. If you're jackknifing the relative RMSE, then of course you don't need to divide by the parameter again, but the formula in the table should be clarified that the jackknifes are on relative RMSE (maybe abbreviate as rRMSE?).

In the second case, it's the relative MSE and relative RMSE that need to be jackknifed, so the formulas should probably clarify that (rMSE and rRMSE?).

On Tue, Mar 24, 2020 at 11:52 PM Megha Joshi notifications@github.com wrote:

One comment. On the relative RMSE MCSE formula you wrote 1/ K times theta squared [image: image] https://user-images.githubusercontent.com/33493716/77502897-2ebc5e00-6e2a-11ea-8d8d-14970140267b.png

But that doesn't show up in the relative variance table [image: image] https://user-images.githubusercontent.com/33493716/77502977-62978380-6e2a-11ea-886f-ea82401e7cda.png

I think if you think that squared theta should be added to relative rmse it should be added to all the relative variance estimates, right?

If I need to add it, I need to change all the formulas in the functions.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/meghapsimatrix/simhelpers/issues/3#issuecomment-603639420, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCVGIWPTLI24EFAJPW74ETRJGE2LANCNFSM4LFIYEFA .

meghapsimatrix commented 4 years ago

I jackknifed the relative RMSE. I changed the notations. Phew. I thought all the formulas were wrong 🤒 but all good!

image

image

Also, I redid welch_res with equal vs unequal sample sizes.

jepusto commented 4 years ago

Looks good!