search

meghlal / timthumb

Automatically exported from code.google.com/p/timthumb
0 stars 0 forks source link

Patch for /trunk/timthumb.php #231

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
It prevents re-sizing if the source is smaller then the new given size.

Original issue reported on code.google.com by bar...@gmail.com on 11 Aug 2011 at 4:23

Attachments:

GoogleCodeExporter commented 8 years ago 
I'm not sure this is desirable behavior. Anyone else have an opinion?

Original comment by mmaun...@gmail.com on 11 Aug 2011 at 5:26

GoogleCodeExporter commented 8 years ago 
I don't know, it works on my site. At least I don't have stretched images 
anymore. But you can also implement it as an option like 
timthumb.php?w=220&prv_res=true/false

Thanks,

Bardhi

Original comment by bar...@gmail.com on 11 Aug 2011 at 5:31

GoogleCodeExporter commented 8 years ago 
I don't think this is something I would want either. The whole point of 
TimThumb is that it resizes images to fit a defined space. If I have an img 
element with a defined size of 100 x 100, and I use TimThumb to crop the image 
then using a 50 x 50 image that is not resized would still result in the image 
being scaled up to 100 x 100 anyway.

Original comment by BinaryMoon on 11 Aug 2011 at 9:08

GoogleCodeExporter commented 8 years ago 
Ok, what if you a case where defined size is 420X300 and you upload an image 
with size let's say 200X200(because you couldn't find bigger image ie. for that 
specific news), what would you do then?

Original comment by bar...@gmail.com on 11 Aug 2011 at 9:56

GoogleCodeExporter commented 8 years ago 
This feels like an edge case because most <img> tags contain width and height 
attributes and expect the image in the src attribute to have the same 
dimensions. It's like you're a heavy for the Bloods in South Central. You need 
to ice someone. The chief tells you his height and weight. You dig a hole. You 
go find him and blow his head off only to discover he's 6ft 3in instead of 5ft 
2in, even with half his head missing. Now you've got this hole in the ground 
with fixed dimensions that you spent a lot of time and effort creating and 
you're going to have to get a chainsaw. It's inefficient and unattractive. 

Setting to WontFix.

Original comment by mmaun...@gmail.com on 12 Aug 2011 at 2:54