search

meghlal / timthumb

Automatically exported from code.google.com/p/timthumb
0 stars 0 forks source link

Where's the final "?>" php bracket at the end of the file? #247

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I'm slightly disturbed that there's no end "?>" php closing bracket at the end 
of the file. Why is it missing, and does that negatively effect the script?

Here's a screenshot: http://screencast.com/t/8rtzc5pYUI2

And here's a link to the source code (currently version 2.8): 
http://timthumb.googlecode.com/svn/trunk/timthumb.php

Original issue reported on code.google.com by webmas...@umstattdmedia.com on 25 Aug 2011 at 8:27

GoogleCodeExporter commented 9 years ago 
Looks like its removed in http://code.google.com/p/timthumb/source/detail?r=107

Original comment by djevrek on 26 Aug 2011 at 5:33

GoogleCodeExporter commented 9 years ago 
why the disturbance? The script works fine. This is a perfectly acceptable PHP 
programming practice. It removes the possibility for stray whitespace to be 
inserted at the end of the file.

http://www.sitepoint.com/should-you-close-your-php-code-tags/

Original comment by BinaryMoon on 28 Aug 2011 at 7:43