meghs94 / tinyos-main

Automatically exported from code.google.com/p/tinyos-main
1 stars 0 forks source link

[patch] Coap client fails to ACK messages, and doesn't ignore empty ACKs #90

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Have the TinyOS CoAP client issue a CoAP request to some entity using 
deferred/separate response for the resource as a CONfirmed message.
2a. Note how the empty ACK to the request gets treated as completion of the 
request, rather than just an indication to stop resends.
2b. Note how the TinyOS CoAP client doesn't acknowledge the message, leading 
the server to keep resending the response.

What is the expected output? What do you see instead?

The CoAP client should send an ACK to received CON messages, and should not 
treat an empty ACK as a query completion. The attached patch corrects both 
these issues.

What version of the product are you using? On what operating system?

2.x trunk.

Please provide any additional information below.

Attached patch assumes patch from previous issue is applied, in order to apply 
cleanly.

Original issue reported on code.google.com by jmatts...@dius.com.au on 25 Nov 2011 at 2:58

Attachments:

GoogleCodeExporter commented 8 years ago
Argh, didn't get the full diff into the first patch. Second patch fixes a 
potential memory leak in the new code from the first patch.

Original comment by jmatts...@dius.com.au on 25 Nov 2011 at 3:02

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by sdh...@gmail.com on 25 Nov 2011 at 5:40

GoogleCodeExporter commented 8 years ago
In r5865.

Original comment by marku...@gmail.com on 12 Jan 2012 at 8:53