vercel[bot]
commented
1 year ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| rdfjs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 30, 2023 6:48pm |
I've added a couple of improvements to the Soukai examples :). The code was fine for the most part, but I changed some things to show you how I would do it.
I also added some inline comments to make it easier to understand, but I think it's better to document it like you have done with all the markdown and such. So feel free to discard this PR and apply the improvements on your own.
The first time I tried to use it I thought the solid example wasn't working, because it was stuck loading after logging in. Turns out that was happening because the default profile in the local POD I'm using for testing doesn't have a name. I could fix that by providing a default value.
It's looking very nice overall, and it was very easy to follow the codebase and apply my changes :). Thanks for working on this!