megvii-research / hpman

A hyperparameter manager for deep learning experiments.
MIT License
95 stars 11 forks source link

pre-commit is currently useless #8

Closed bigeagle closed 4 years ago

bigeagle commented 4 years ago

Running pre-commit run --all-files on the current master branch, I got

black....................................................................Passed
Flake8...................................................................Passed
Trim Trailing Whitespace.................................................Failed
hookid: trailing-whitespace

Files were modified by this hook. Additional output:

Fixing .travis.yml
Fixing .git-commit-template.txt
Fixing README.md

Fix requirements.txt.....................................................Passed
Check for added large files..............................................Passed
Check docstring is first.................................................Passed
Check that executables have shebangs.....................................Passed
Check for merge conflicts................................................Passed
Debug Statements (Python)................................................Passed
Fix End of Files.........................................................Passed
mypy.....................................................................Failed
hookid: mypy

examples/01-two-files/main.py: error: Duplicate module named 'main' (also at 'examples/00-basic/main.py')

The tailing whitespace is easy to solve, so let's ignore it. However, I can hardly make mypy pass since