search

meh / elixir-socket

Socket wrapping for Elixir.
691 stars 119 forks source link

Compilation Warnings #89

Closed nelsonic closed 6 years ago

nelsonic commented 6 years ago

Hi @meh thanks very much for this superb package! When compiling using Elixir v.1.6 we see the following warnings: image

Compiling 11 files (.ex)
warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  lib/socket/address.ex:19

warning: the char_list() type is deprecated, use charlist()
  lib/socket/address.ex:12

warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  lib/socket/host.ex:61

warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  lib/socket/host.ex:75

warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  lib/socket/host.ex:89

warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  lib/socket/host.ex:103

warning: the char_list() type is deprecated, use charlist()
  lib/socket/host.ex:101

warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  lib/socket/datagram.ex:54

warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  lib/socket/ssl.ex:141

warning: String.to_char_list/1 is deprecated, use String.to_charlist/1
  lib/socket/tcp.ex:108

Would you accept a Pull Request updating the relevant function invocations to avoid the warnings? (thanks in advance)

meh commented 6 years ago

See #88.

nelsonic commented 6 years ago

@meh sweet! thanks! 👍