meh / rust-ffmpeg

Safe FFmpeg wrapper.
Do What The F*ck You Want To Public License
461 stars 96 forks source link

fix resampling::Context flush documentation #163

Closed kcking closed 1 year ago

kcking commented 2 years ago

In the interest of not making a backwards-incompatible change to the api -- here's a documentation fix for flush.

If a version bump is on the table, I would probably propose removing Delay from the return value and either returning Ok(output.samples()) (where Ok(0) is the finished case), or just Ok(()) and let the user check the output buffer.

Addresses https://github.com/meh/rust-ffmpeg/issues/162