search

meh / rust-terminfo

Terminal information for Rust.
Other
40 stars 15 forks source link

handle non-FHS systems #12

Closed mitnk closed 4 years ago

mitnk commented 5 years ago

Fixes #11

mitnk commented 5 years ago

Replaced env::home_dir() with dirs::home_dir() as rustc suggests:

warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
   --> src/database.rs:170:28
    |
170 |             if let Some(mut home) = env::home_dir() {
    |                                     ^^^^^^^^^^^^^
    |
    = note: #[warn(deprecated)] on by default

For the CI fails, I don't know the reason. Master fails too #10. Could you help to have a check?

mitnk commented 4 years ago

This PR is ready for another review. Thanks!

meh commented 4 years ago

Can you remove the version bump? I usually do that in another commit.

Looks good otherwise, I'll merge as soon as that's removed :panda_face:

meh commented 4 years ago

Thanks a bunch!