search

meh / rust-terminfo

Terminal information for Rust.
Other
40 stars 15 forks source link

Run `rustfmt` #24

Closed SabrinaJewson closed 1 year ago

SabrinaJewson commented 1 year ago

Automated formatting is hugely beneficial to the contribution process since it eliminates any back-and-forth about style, even if it is imperfect at times; especially since there is more than one maintainer this is important. To avoid too many changes in the commit that actually formats everything, I adjusted the rustfmt settings slightly to allow longer lines.

wez commented 1 year ago

FWIW, I'm 100% behind automated formatting; I almost don't care what the coding style actually is, so long as the formatter will apply it!

This PR is +1 from me, but it would be courteous to give @meh a chance to comment on the style that it applies before merging it.

andersk commented 1 year ago

I like rustfmt, but can we first merge #25, which replaces all the Nom macros that rustfmt can’t deal with well?

Edit: that’s merged now, carry on!

SabrinaJewson commented 1 year ago

It’s now been nearly two months — although meh did originally make this project I think at this point it’s unlikely they will participate in the development of this any further. So, I propose we merge this and then work on cutting a new version with Nom 7.