Closed pinkisemils closed 5 years ago
Could you use tabs everywhere instead of mixed spaces/tabs please?
Sure, completely missed that.
Hiya, don't want to bug you much, but I think now this is mergeable!
Any update on this? Would be really nice to have available without relying on a fork :ok_hand:
The update is I'm stupid and I didn't click the "finish review" button, so I was waiting for an answer that would have never come.
Thanks! And sorry for the huge delay.
I noticed the lack of
AsRawFd
for theDevice
struct on MacOS, so I've implemented that and alsoIntoRawFd
, as that's my actual use case. If however you don't wish to have the device be capable of being irreversibly turned into a raw file descriptor, I'm OK with not making that change :slightly_smiling_face:This change is![Reviewable](https://reviewable.io/review_button.svg)