search

meh / rust-tun

TUN device creation and handling.
343 stars 136 forks source link

Add raw fd traits #10

Closed pinkisemils closed 5 years ago

pinkisemils commented 5 years ago

I noticed the lack of AsRawFd for the Device struct on MacOS, so I've implemented that and also IntoRawFd, as that's my actual use case. If however you don't wish to have the device be capable of being irreversibly turned into a raw file descriptor, I'm OK with not making that change :slightly_smiling_face:

This change is Reviewable

meh commented 5 years ago

Could you use tabs everywhere instead of mixed spaces/tabs please?

pinkisemils commented 5 years ago

Sure, completely missed that.

pinkisemils commented 5 years ago

Hiya, don't want to bug you much, but I think now this is mergeable!

faern commented 5 years ago

Any update on this? Would be really nice to have available without relying on a fork :ok_hand:

meh commented 5 years ago

The update is I'm stupid and I didn't click the "finish review" button, so I was waiting for an answer that would have never come.

meh commented 5 years ago

Thanks! And sorry for the huge delay.