Closed kings-way closed 3 years ago
Hey guys, it's good to have multiqueue support now, but it breaks trait IntoRawFd for Device. see here https://github.com/meh/rust-tun/blob/master/src/platform/linux/device.rs#L381
IntoRawFd
Device
I think it may cause some trouble if someone calls into_raw_fd() to transfer the ownership of RawFd, cause when Device is dropped, the underlying fd will be closed.
into_raw_fd()
RawFd
@jibi :panda_face:
Hey guys, it's good to have multiqueue support now, but it breaks trait
IntoRawFd
forDevice
. see here https://github.com/meh/rust-tun/blob/master/src/platform/linux/device.rs#L381I think it may cause some trouble if someone calls
into_raw_fd()
to transfer the ownership ofRawFd
, cause whenDevice
is dropped, the underlying fd will be closed.