search

meh / rust-tun

TUN device creation and handling.
343 stars 136 forks source link

Bump ioctl-sys to 0.6 #28

Closed Ch00k closed 3 years ago

Ch00k commented 3 years ago

This adds support for Apple Silicon. Support for it in ioctl-sys was introduced in this PR: https://github.com/jmesmon/ioctl/pull/7

meh commented 3 years ago

Thanks, I'm going to try to merge this and publish a new package when I get home.

But please, if I don't, don't feel like you're bothering me with pings, I'm quite busy and tired so it's more likely that I got home and fell asleep than anything, so do ping me if I don't, even multiple times, or send a message pigeon with a firecracker or something.

faern commented 3 years ago

Yay! Awesome to have it merged. Would it be possible to have a (patch?) release published with this?

meh commented 3 years ago

Yeah, I was working on that, then I noticed tokio was outdated, so I started upgrading, but mio was also outdated, and then I fell asleep.

I'll try to finish that later today and release a new version :)

faern commented 3 years ago

Can we please have a tun release that depends on tokio 0.2 first/also? :pray:

Many of us are still stuck with tokio 0.2 and can't upgrade in the forseeable future. So if you change tun we will not be able to upgrade.

faern commented 3 years ago

A quick patch release just allowing Apple Silicon via the bumped ioctl-sys would be amazing (0.5.1)! And then there can be a separate breaking change for the new tokio ecosystem? (0.6.0)

meh commented 3 years ago

Of course, I'll do that when I get to the studio.

meh commented 3 years ago

@faern it's up on crates!

faern commented 3 years ago

Thank you @meh ! <3