search

meh / rust-tun

TUN device creation and handling.
340 stars 133 forks source link

clean code #74

Open ssrlive opened 8 months ago

ssrlive commented 8 months ago

due to libc crate updated, ifreq struct added

xmh0511 commented 7 months ago

@meh Please take a look at this patch for enhancing read/write performance on Windows platform.

fujiapple852 commented 6 months ago

Stumbled on this PR whilst debugging an issue in CI.

Assuming the changes here are the same as those from https://github.com/ssrlive/rust-tun e944758112d23a2199b0c8d8adf8ffc6a8c1e9f5, then this PR fixes the issues I've been seeing using this crate with async code on Windows from Github CI (see https://github.com/fujiapple852/trippy/pull/891 for WIP code which work with the fork and fails sporadically with rust-run).

I haven't bisected exactly which change here fixes the issue, as I've only just discovered this to be the cause, but I will.

ssrlive commented 6 months ago

Hi @meh , If you really don't have time to maintain this repo and crate, I would like you to add me as a co-contributor and publisher. what do you think?

ssrlive commented 6 months ago

Hi @meh, if this PR has not been responded a week later, I will have to publish tun2 crate, and I don't want this to happen. Hope you can respond in time.

For me, a submitted PR has not been reviewed for a long time, cannot be merged to the main branch, and cannot be published. It is like a patient who has not been sutured on the operating table for a long time. This is a bad experience. I believe that many people feel the same.

pronebird commented 4 months ago

The changes are all over the place. It would be easier to accept if you narrowed your scope and instead pushed a few more focused and smaller PRs.