search

meh / rust-xcb-util

Rust bindings and wrappers for XCB utility functions.
MIT License
27 stars 17 forks source link

Provide a way to get string out of GetWmNameReply. #6

Closed mjkillough closed 7 years ago

mjkillough commented 7 years ago

Adds a string() method to GetWmNameReply, to return the name contained within the reply. (The name mirrors the strings() method on GetDesktopNamesReply(), but 'as_string()` might have been more appropriate).

meh commented 7 years ago

Thanks, merged.

About the naming for them, I was following the naming scheme that XCB uses get_utf8_strings_reply, it might be more meaningful to additionally implement AsRef<str> or something on those lines, but then it doesn't work for GetDesktopNamesReply.

Any ideas?

mjkillough commented 7 years ago

I think the current naming scheme is fine. Thanks for the library and for merging these!